LGTM from my end. But it would be nice if Ross could also take a look.
https://codereview.chromium.org/236063015/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/236063015/diff/1/src/heap.cc#newcode5958
src/heap.cc:5958: if (max_old_generation_size_ <= 256 * MB) {
I personally am fine with hard-coding this constant. But I am not sure
how much this duplicates "magic constants" between embedders and V8. I
am deferring to Ross' opinion about this.
https://codereview.chromium.org/236063015/diff/1/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/236063015/diff/1/src/heap.h#newcode1890
src/heap.h:1890: int old_generation_growing_factor_;
nit: Can we haz short comment of the semantics?
https://codereview.chromium.org/236063015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
