One suggestion, but otherwise lgtm. Thanks!
https://codereview.chromium.org/236063015/diff/70001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/236063015/diff/70001/src/api.cc#newcode473
src/api.cc:473: const int lump_of_memory = (i::kPointerSize / 4) *
i::MB;
nit - if you move lump_of_memory, to heap.h too, then the sizes could be
simply in MB (and the growth factor check would match the heap size even
on 64bit device).
https://codereview.chromium.org/236063015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
