https://codereview.chromium.org/236063015/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/236063015/diff/1/src/heap.cc#newcode5958
src/heap.cc:5958: if (max_old_generation_size_ <= 256 * MB) {
On 2014/04/15 12:11:50, Michael Starzinger wrote:
I personally am fine with hard-coding this constant. But I am not sure
how much
this duplicates "magic constants" between embedders and V8. I am
deferring to
Ross' opinion about this.
Done.
https://codereview.chromium.org/236063015/diff/1/src/heap.cc#newcode5958
src/heap.cc:5958: if (max_old_generation_size_ <= 256 * MB) {
On 2014/04/15 12:43:01, rmcilroy wrote:
On 2014/04/15 12:11:50, Michael Starzinger wrote:
> I personally am fine with hard-coding this constant. But I am not
sure how
much
> this duplicates "magic constants" between embedders and V8. I am
deferring to
> Ross' opinion about this.
I'm fine with this being hard-coded as well, but could we extract a
constant
somewhere for the 256MB and use it both here and in
ResourceConstraints::ConfigureDefaultS? That way, if we decide to
change the
heap size of a low-mem device it will change both places.
Done.
https://codereview.chromium.org/236063015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
