https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h#newcode660
src/flag-definitions.h:660: DEFINE_bool(omit, false, "Omit raw snapshot
bytes in generated code.")
These new flags don't make sense outside of mksnapshot, can we find a
way to restrict them to that? Having them e.g. in d8 is a bit confusing.
I know this problem has been there before, but now we have 4 confusing
flags instead of 1.
https://codereview.chromium.org/249283002/diff/20001/src/mksnapshot.cc
File src/mksnapshot.cc (right):
https://codereview.chromium.org/249283002/diff/20001/src/mksnapshot.cc#newcode75
src/mksnapshot.cc:75: ~SnapshotWriter() {
Here and below: We normally use 1 blank line between function
definitions in classes and 2 blank lines between out-of-line function
definitions. We sometimes deviate from these rules for single one-line
getter/setter functions.
https://codereview.chromium.org/249283002/diff/20001/src/mksnapshot.cc#newcode116
src/mksnapshot.cc:116: void WriteData(const char* prefix, const
i::List<char>& source_data,
Here and at other places: If parameters don't fit on a line, we usually
have a single parameter per line.
https://codereview.chromium.org/249283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
