On 2014/04/24 11:12:43, Sven Panne wrote:
LGTM with a nit
https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/249283002/diff/20001/src/flag-definitions.h#newcode660
src/flag-definitions.h:660: DEFINE_bool(omit, false, "Omit raw snapshot
bytes
in
generated code.")
On 2014/04/24 11:07:59, vogelheim wrote:
> [...] Honestly, I'm not super fond of this design, but I can't see any
fix
other than
> refactoring the whole flags thing.
I suspected that... :-/ OK, then just add "(mksnapshot only)" to the
descriptions.
Done.
https://codereview.chromium.org/249283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
