https://codereview.chromium.org/249503002/diff/100001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/249503002/diff/100001/src/promise.js#newcode185
src/promise.js:185:
On 2014/04/24 14:33:47, rossberg wrote:
nit: spurious new line
Done.
https://codereview.chromium.org/249503002/diff/100001/src/promise.js#newcode197
src/promise.js:197: if (!IS_SPEC_FUNCTION(deferred.reject)) {
On 2014/04/24 14:33:47, rossberg wrote:
Why do you have to test this case? It will throw in the 'try' below
anyway (and
be handled appropriately).
Yeah, it will throw, with a TypeError 'undefined is not a function' as
exception. The original exception is then gone. That seems unintuitive.
https://codereview.chromium.org/249503002/diff/100001/test/mjsunit/es6/debug-promises-caught-uncaught.js
File test/mjsunit/es6/debug-promises-caught-uncaught.js (right):
https://codereview.chromium.org/249503002/diff/100001/test/mjsunit/es6/debug-promises-caught-uncaught.js#newcode32
test/mjsunit/es6/debug-promises-caught-uncaught.js:32: } else if (event
== Debug.DebugEvent.PendingExceptionInPromise) {
On 2014/04/24 14:33:47, rossberg wrote:
Use a single if with ||
Done.
https://codereview.chromium.org/249503002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
