https://codereview.chromium.org/249503002/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/249503002/diff/1/src/runtime.cc#newcode5660
src/runtime.cc:5660: isolate->debugger()->OnException(exception, false,
deferred_promise);
On 2014/04/24 07:59:59, Yang wrote:
On 2014/04/24 07:48:43, yurys wrote:
> It might make sense to report the exception as uncaught=true here in
case
there
> is no catch handler on the promise yet.
Done.
Alternatively, we could always fire this runtime function, and set
uncaught
depending on whether we already have a catch handler. Devtools would
then filter
out caught ones. That would give you guys more flexibility (not sure
if
necessary).
I believe this is not necessary. We have three modes in DevTools:
1) don't pause on exception
2) pause on uncaught exceptions only (controlled by
Debug.setBreakOnUncaughtException();)
3) pause on all exceptions (controlled by Debug.setBreakOnException();)
All of them are handled in v8 at the moment and I believe the promises
should follow that logic too.
https://codereview.chromium.org/249503002/diff/20001/test/mjsunit/es6/debug-promises-uncaught.js
File test/mjsunit/es6/debug-promises-uncaught.js (right):
https://codereview.chromium.org/249503002/diff/20001/test/mjsunit/es6/debug-promises-uncaught.js#newcode30
test/mjsunit/es6/debug-promises-uncaught.js:30: if (event ==
Debug.DebugEvent.Exception) {
Would be nice to also test that this branch is not executed if
Debug.setBreakOnUncaughtException(); was called instead of
Debug.setBreakOnException(); at line 54. That would match "Pause on
uncaught exceptions only" in DevTools.
https://codereview.chromium.org/249503002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
