lgtm
https://codereview.chromium.org/249503002/diff/40001/src/debug.cc File src/debug.cc (right): https://codereview.chromium.org/249503002/diff/40001/src/debug.cc#newcode2700 src/debug.cc:2700: promise = isolate_->factory()->undefined_value(); maybe set undefined to promise by default instead of null? then this line will go away naturally https://codereview.chromium.org/249503002/diff/40001/src/promise.js File src/promise.js (right): https://codereview.chromium.org/249503002/diff/40001/src/promise.js#newcode199 src/promise.js:199: try { deferred.reject(e) } catch(e) { nit: expand try { ... } ? https://codereview.chromium.org/249503002/diff/40001/test/mjsunit/es6/debug-promises-caught.js File test/mjsunit/es6/debug-promises-caught.js (right): https://codereview.chromium.org/249503002/diff/40001/test/mjsunit/es6/debug-promises-caught.js#newcode9 test/mjsunit/es6/debug-promises-caught.js:9: var resolve_fun; remove https://codereview.chromium.org/249503002/diff/40001/test/mjsunit/es6/debug-promises-uncaught.js File test/mjsunit/es6/debug-promises-uncaught.js (right): https://codereview.chromium.org/249503002/diff/40001/test/mjsunit/es6/debug-promises-uncaught.js#newcode9 test/mjsunit/es6/debug-promises-uncaught.js:9: var resolve_fun; remove https://codereview.chromium.org/249503002/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
