lgtm! Very cool.
Just a couple of suggestions.
https://codereview.chromium.org/250923002/diff/1/tools/generate-runtime-tests.py
File tools/generate-runtime-tests.py (right):
https://codereview.chromium.org/250923002/diff/1/tools/generate-runtime-tests.py#newcode257
tools/generate-runtime-tests.py:257: return "%s.js" % self.name.lower()
Suggestion: why lowercase names for tests? It's ok to have mixed-case
filenames, and easier to map function name to test case.
https://codereview.chromium.org/250923002/diff/1/tools/generate-runtime-tests.py#newcode475
tools/generate-runtime-tests.py:475: print("Missing testcase for %s,
please run '%s generate'" %
Suggestion: would also be awesome to check if file is added to git.
https://codereview.chromium.org/250923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
