I'll expand on the tests. Make sure all code paths are covered.
https://codereview.chromium.org/289503002/diff/100001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/289503002/diff/100001/src/objects.cc#newcode16301
src/objects.cc:16301:
On 2014/05/14 17:21:36, rossberg wrote:
Add an assertion here that removed_holes_index == nod.
Done.
https://codereview.chromium.org/289503002/diff/100001/src/objects.cc#newcode16518
src/objects.cc:16518: index = 0;
On 2014/05/14 17:21:36, rossberg wrote:
At this point we can actually break the outer loop.
No. We need to update the table field to point to the newest table.
In fact, we can always do that when index becomes 0. Maybe simply add
"index > 0
&&" to the while condition instead of inserting a break here.
I'll add an index == 0 check though.
https://codereview.chromium.org/289503002/diff/100001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/289503002/diff/100001/src/objects.h#newcode4229
src/objects.h:4229: bool IsDeprecated() {
On 2014/05/14 17:21:36, rossberg wrote:
We have a concept of "deprecation" for maps, which is unrelated. Just
to avoid
confusion, maybe we should use a different name here (e.g. IsOutdated
or
IsRehashed).
IsObsolete
https://codereview.chromium.org/289503002/diff/100001/src/objects.h#newcode4230
src/objects.h:4230: return !get(kNumberOfElementsIndex)->IsSmi();
On 2014/05/14 17:21:36, rossberg wrote:
We could define a separate constant for this (and other slots), that
just alias
the one it's overlaying.
Done.
https://codereview.chromium.org/289503002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
