On 2014/05/15 09:09:34, rossberg wrote:
The implementation looks good to go, but it would be preferable to also
have
separate tests where
- the iterator ends up not having any next element anymore after the
resync
- the new table ends up being entirely empty (but through individual
deletes
only)
- a non-trivial transition chain with length > 1 is created (esp. one that
does
not leave the iterator at index 0, i.e., does not involve clear)
I added tests for these cases too. It was not easy to construct tests that
hits
these cases so I instrumented my code to make sure I got into the desired
state.
https://codereview.chromium.org/289503002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
