PTAL
https://codereview.chromium.org/289503002/diff/140001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/289503002/diff/140001/src/objects.cc#newcode16244
src/objects.cc:16244: if (nof >= (capacity >> 2)) return table;
Since kMinCapacity is 4 we end up with nof=1 not being enough to prevent
a shrink which lead us to shrink this to 2 which is not desirable.
Another option would be to do:
if (capacity == kMinCapacity || nof >= (capacity >> 2)) return table;
https://codereview.chromium.org/289503002/diff/140001/src/objects.cc#newcode16527
src/objects.cc:16527: if (removed_index >= old_index) break;
This was wrong before. We need to compare with the index before we
decremented index.
https://codereview.chromium.org/289503002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
