Nice cleanup. Tested with --no-snapshot, valgrind etc., I hope... ;-) The
only
thing which is unclear to me is the change in the use_crankshaft()
predicate.
https://codereview.chromium.org/296853007/diff/1/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/296853007/diff/1/src/isolate.h#newcode968
src/isolate.h:968: bool serializer_enabled() { return
serializer_enabled_; }
const
https://codereview.chromium.org/296853007/diff/1/src/isolate.h#newcode974
src/isolate.h:974: return use_crankshaft_ && !serializer_enabled_;
Hmmm, why do we need this additional term?
https://codereview.chromium.org/296853007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.