On 2014/05/22 08:56:49, Sven Panne wrote:
On 2014/05/22 08:46:06, Yang wrote:
> [...] I now changed this so that the serializer state has to be set
before
> Isolate::Init, and use_crankshaft_ is set based on the serializer state.
Hmmm, I think that is still not completely right: It would really simplify
things quite a lot when we can merge the Isolate constructor and
Isolate::Init
into just the constructor. Previously this split was necessary because of
the
default Isolate which was half-constructed before main(), but this reason
has
gone.
use_crankshaft_ seems to be just a tiny cache, can't we use inline the
stuff
into the use_crankshaft() predicate and kill use_crankshaft_?
Done.
https://codereview.chromium.org/296853007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
