Changed slightly. What I can say is that at there are at least no new leaks
added by this CL. I'll work on reducing the leaks though.


https://codereview.chromium.org/296853007/diff/1/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/296853007/diff/1/src/isolate.h#newcode968
src/isolate.h:968: bool serializer_enabled() { return
serializer_enabled_; }
On 2014/05/22 08:04:15, Sven Panne wrote:
const

Done.

https://codereview.chromium.org/296853007/diff/1/src/isolate.h#newcode974
src/isolate.h:974: return use_crankshaft_ && !serializer_enabled_;
On 2014/05/22 08:04:15, Sven Panne wrote:
Hmmm, why do we need this additional term?

My mistake. Some point during refactoring I thought it was a good idea
to be able to disable serializer.

I now changed this so that the serializer state has to be set before
Isolate::Init, and use_crankshaft_ is set based on the serializer state.

https://codereview.chromium.org/296853007/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to