https://codereview.chromium.org/316173002/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/316173002/diff/20001/src/parser.cc#newcode3853
src/parser.cc:3853: while (name_start < data.length() &&
data[name_start] == ' ') {
This won't work for \tname=. Also the original pattern assumed exactly
one whitespace character between @ and sourceURL
https://codereview.chromium.org/316173002/diff/20001/src/parser.cc#newcode3862
src/parser.cc:3862: while (value_start < data.length() &&
data[value_start] == ' ') {
Same here, the original pattern was [\040\t]sourceURL=[\040\t]*
https://codereview.chromium.org/316173002/diff/20001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/316173002/diff/20001/src/parser.h#newcode788
src/parser.h:788: void ParseSourceMapComment();
The name is a bit misleading as we actually parse sourceURL not
sourceMappingURL.
https://codereview.chromium.org/316173002/diff/20001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/316173002/diff/20001/src/scanner.cc#newcode477
src/scanner.cc:477: token = SkipSourceMapComment();
I believe we should consider only sourceURL that are at the end of file.
If there is something like
function foo(){}
//@ sourceURL = url.js
function bar(){}
we should skip the url as far as I remember.
https://codereview.chromium.org/316173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
