Nice. High-level comments; I'm too tired right now to study the details for
correctness.
https://codereview.chromium.org/352583002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/352583002/diff/20001/src/code-stubs.h#newcode351
src/code-stubs.h:351: // if hint_stack_parameter_count_ > 0, the code
stub can optimize the
nit: s/if/If/
https://codereview.chromium.org/352583002/diff/20001/src/code-stubs.h#newcode363
src/code-stubs.h:363: // assumed to be Tagged()
nit: trailing full stop
https://codereview.chromium.org/352583002/diff/20001/src/code-stubs.h#newcode364
src/code-stubs.h:364: Representation* register_param_representations_;
This should probably be a SmartArrayPointer too, but feel free to punt
on that.
https://codereview.chromium.org/352583002/diff/20001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/352583002/diff/20001/src/ia32/code-stubs-ia32.cc#newcode27
src/ia32/code-stubs-ia32.cc:27: register_params_ =
SmartArrayPointer<Register>(
As discussed:
(1) this can (hopefully!) go into the platform-independent code-stubs.cc
(2) let's use .Reset() instead of operator=.
https://codereview.chromium.org/352583002/diff/20001/src/ia32/code-stubs-ia32.cc#newcode39
src/ia32/code-stubs-ia32.cc:39: 1, registers,
How about s/1/ARRAY_SIZE(registers)/ ? Less likely to be wrong, but more
verbose -- I'm not sure it'd be an improvement.
https://codereview.chromium.org/352583002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
