Thanks for comments thus far, updated to "state of the art" for your
eye-straining pleasure. :p
--Michael
ps - Sven - 2017, only three years right? :D
https://codereview.chromium.org/352583002/diff/20001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/352583002/diff/20001/src/code-stubs.h#newcode351
src/code-stubs.h:351: // if hint_stack_parameter_count_ > 0, the code
stub can optimize the
On 2014/06/24 17:23:24, Jakob wrote:
nit: s/if/If/
Done.
https://codereview.chromium.org/352583002/diff/20001/src/code-stubs.h#newcode363
src/code-stubs.h:363: // assumed to be Tagged()
On 2014/06/24 17:23:24, Jakob wrote:
nit: trailing full stop
Done.
https://codereview.chromium.org/352583002/diff/20001/src/code-stubs.h#newcode364
src/code-stubs.h:364: Representation* register_param_representations_;
On 2014/06/24 17:23:24, Jakob wrote:
This should probably be a SmartArrayPointer too, but feel free to punt
on that.
Yep, I did this because otherwise the asymmetry is jarring.
https://codereview.chromium.org/352583002/diff/20001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/352583002/diff/20001/src/ia32/code-stubs-ia32.cc#newcode27
src/ia32/code-stubs-ia32.cc:27: register_params_ =
SmartArrayPointer<Register>(
On 2014/06/24 17:23:24, Jakob wrote:
As discussed:
(1) this can (hopefully!) go into the platform-independent
code-stubs.cc
(2) let's use .Reset() instead of operator=.
Done.
https://codereview.chromium.org/352583002/diff/20001/src/ia32/code-stubs-ia32.cc#newcode39
src/ia32/code-stubs-ia32.cc:39: 1, registers,
On 2014/06/24 17:23:24, Jakob wrote:
How about s/1/ARRAY_SIZE(registers)/ ? Less likely to be wrong, but
more verbose
-- I'm not sure it'd be an improvement.
Let's do it, because already arm64 made that change on it's own.
https://codereview.chromium.org/352583002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
