https://codereview.chromium.org/352583002/diff/20001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/352583002/diff/20001/src/ia32/code-stubs-ia32.cc#newcode39
src/ia32/code-stubs-ia32.cc:39: 1, registers,
On 2014/06/24 17:23:24, Jakob wrote:
How about s/1/ARRAY_SIZE(registers)/ ? Less likely to be wrong, but
more verbose
-- I'm not sure it'd be an improvement.
We discussed similar things yesterday, another (IMHO slightly nicer)
approach would be adding a NULL sentinel to registers and let Initialize
count the stuff. Old skool... ;-)
The *right* approach (locally) would of course be using a std::vector
with a brace initializer. Perhaps in 2017...
https://codereview.chromium.org/352583002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
