On 2014/06/24 16:08:39, aperez wrote:
On 2014/06/18 at 16:21:17, marja wrote:
> https://codereview.chromium.org/160073006/diff/520001/src/scanner.h
> File src/scanner.h (right):
>
>
https://codereview.chromium.org/160073006/diff/520001/src/scanner.h#newcode767
> src/scanner.h:767: }
> Btw, I don't think this state machine works anyway, for example:
>
> (foo, bar, (baz, quux) => { ... });
>
> Could you add tests for such cases, to verify that the stuff inside is
correctly identified as an arrow function (e.g., that the appropriate
errors
are
produced).
Mmmh, wouldn't this case be parsed the same as this?:
(foo, bar, ((baz, quux) => { ... }));
If I am understanding correctly, the way the grammar is specified, the
expression would be picked as a comma-separated list of expressions,
being the last expression an arrow function... So this would be correct
input, am I right?
Or did you mean that the ParamListFinder would have caused an error
for that valid input?
(Anyway, I am getting rid of ParamListFinder, CL to be updated soon.)
Yes, I meant that ParamListFinder would have caused error for this valid
input
(it wouldn't have recognized the parameter list).
https://codereview.chromium.org/160073006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
