On Fri, Jun 21, 2013 at 9:19 AM, Dan Carney <[email protected]> wrote:
> The transition from Local to Handle won't happen for a while. It's more of
> a cleanup step after everything else is done, and there's no urgency since
> there shouldn't be any performance impact. At that point, we'll add some
> cutover functions and #defines to make transition easier.
Dan, Handle and Local contain these snippets:
// TODO(dcarney): remove before cutover
V8_INLINE(static Handle<T> New(Isolate* isolate, const
Persistent<T>& that)) {
return New(isolate, that.val_);
}
And:
// TODO(dcarney): remove before cutover
V8_INLINE(static Local<T> New(Isolate* isolate, const Persistent<T>& that));
Is that comment in error? Put another way: if or when those functions
are removed, how are you supposed to get at the handle that the
Persistent points to?
Another thing is Persistent<T>::ClearAndLeak(). Here is its definition:
V8_INLINE(T* ClearAndLeak());
What purpose does it serve? You can't construct a Handle<T> from a
raw T*, all constructors and New() class methods that take a T* are
private.
--
--
v8-users mailing list
[email protected]
http://groups.google.com/group/v8-users
---
You received this message because you are subscribed to the Google Groups
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
