On Mon, Jul 8, 2013 at 12:53 AM, Dan Carney <[email protected]> wrote:

> I'm not quite sure what you mean.  Do you mean you want to return a value
> stored in a Persistent? If so, that's done via
> GetReturnValue().Set(Persistent&).  That should take care of the regression
> if that's the case.  If not, could you provide me with an example?
>

Say for example the Persistent<Object>* passed to the MakeWeak callback.
Before 3.20 it was possible to
 Object::GetIndexedPropertiesExternalArrayDataLength() directly on the
Persistent, but now it's necessary to Local<Object>::New() first. Or a
worse case is where both a Function and Object are cached as Persistent<T>
it's then necessary to do something like the following:

Local<Function>::New(isolate, p_fn)->Call(Local<Object>::New(isolate,
p_obj), argc, argv[]);

Constantly needing to create a Local<T>::New() every time I need to use a
Persistent<T> in cases like the above isn't playing nicely. I've noticed
since the change that GC time from --prof has grown around 5% in high I/O
scenarios.

-- 
-- 
v8-users mailing list
[email protected]
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to