On Fri, 6 Mar 2026 21:50:57 GMT, Frederic Parain <[email protected]> wrote:

>> Small patch fixing a missing memory barrier in FlatArrayKlass::copy_array.
>> The unit test covers more scenario where a flat value has to be buffered 
>> before to be written to another heap variable. So far, these tests haven't 
>> shown any other issue (they were run repeatedly 50 times using Mach5).
>> 
>> However, the unit test is quite heavy, testing 5 different scenarios, and 
>> running each for 3 minutes, using all detected cores of the machine each 
>> time. This might qualify this unit test as a "resourcehog" test, it then 
>> should be moved to test/hotspot/jtreg/resourcehogs/
>> 
>> Fred
>
> Frederic Parain has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Move barrier to buffering code
>  - Fix jtreg tags

To me this looks like a safer approach. Thanks. I've not reviewed the test.

-------------

Marked as reviewed by stefank (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2183#pullrequestreview-3915469534

Reply via email to