On Fri, 6 Mar 2026 11:13:07 GMT, David Beaumont <[email protected]> wrote:
>> make/common/JavaCompilation.gmk line 306: >> >>> 304: # source root, which are not being recompiled in this compilation: >>> 305: $1_AUGMENTED_CLASSPATH += $$($1_BIN) >>> 306: $1_PROCESSOR_PATH += $$(BUILDTOOLS_OUTPUTDIR)/depend >> >> Why this change? Do you really need to mess with the API digest plugin? If >> this is needed, then please document any new parameters on the >> SetupJavaCompilation macro. > > This changed because the compiler is bimodal and *either* takes the processor > path from "processor-path" *or* it takes it from the service provider info > (which I don't think is the right approach here). > However this also is the plugin path. > > So if you add `--processor-path` you break the depend plugin, because it > *used* to use the *classpath*, but now that mechanism is disabled in favour > of the *processor path*. > > Thus it is necessary to also add the depend plugin path to the processor path. > > This is achieving exactly the same thing as before and is an internal detail, > and without it, you cannot specify an annotation processor path. > > I'm happy to add documentation wherever you feel it necessary/helpful, please > make suggestion as you see fit. I added a couple of lines of docs in JavaCompilation.gmk (please take a look) but also am now wondering about the naming inconsistency between "CLASSPATH" and "PROCESSOR_PATH". Do you want me to change it to "PROCESSORPATH" ? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2180#discussion_r2896034091
