> Adds a new AnnotationProcessor to read the @MigratedValueClass on prospective 
> value classes and generate the equivalent source file with the 'value' 
> keyword at each annotated class declaration.
> 
> This adds new PROCESSOR_PATH variable to the compilation macro and use it for 
> annotation processing.
> This also requires moving the plugin discovery path to the new variable (was 
> in classpath before) because the addition of a '--processor-path' flag 
> disables using the classpath for plugin discovery.
> 
> For now this is all limited to `java.base` but that's expandable later 
> easily. There was an issue just enabling it for all modules however (esp. 
> `jdk.incubator` which might be special).
> 
> While there is currently no specific unit test for this code, if it were to 
> fail to generate the correct value classes, a lot of other downstream tests 
> would fail.

David Beaumont has updated the pull request incrementally with two additional 
commits since the last revision:

 - remove old version
 - Addressing some feedback.

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2180/files
  - new: https://git.openjdk.org/valhalla/pull/2180/files/64a70a64..881192fd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2180&range=05
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2180&range=04-05

  Stats: 290 lines in 2 files changed: 2 ins; 286 del; 2 mod
  Patch: https://git.openjdk.org/valhalla/pull/2180.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2180/head:pull/2180

PR: https://git.openjdk.org/valhalla/pull/2180

Reply via email to