> Adds a new AnnotationProcessor to read the @MigratedValueClass on prospective 
> value classes and generate the equivalent source file with the 'value' 
> keyword at each annotated class declaration.
> 
> This adds new PROCESSOR_PATH variable to the compilation macro and use it for 
> annotation processing.
> This also requires moving the plugin discovery path to the new variable (was 
> in classpath before) because the addition of a '--processor-path' flag 
> disables using the classpath for plugin discovery.
> 
> For now this is all limited to `java.base` but that's expandable later 
> easily. There was an issue just enabling it for all modules however (esp. 
> `jdk.incubator` which might be special).
> 
> While there is currently no specific unit test for this code, if it were to 
> fail to generate the correct value classes, a lot of other downstream tests 
> would fail.

David Beaumont has updated the pull request incrementally with one additional 
commit since the last revision:

  better but still not working

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2180/files
  - new: https://git.openjdk.org/valhalla/pull/2180/files/5ac41dea..9f7ba1cf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2180&range=08
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2180&range=07-08

  Stats: 26 lines in 3 files changed: 23 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/valhalla/pull/2180.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2180/head:pull/2180

PR: https://git.openjdk.org/valhalla/pull/2180

Reply via email to