> Hi everyone,
> 
> The `objArrayOop` gtest currently only tests reference arrays, but should 
> also test on flat arrays. This is reflected by a `FIXME` at the top of the 
> file. 
> 
> For this change I expanded the test to also cover flat arrays. The original 
> tested options for ref arrays (mostly related to header size and layout) make 
> less sense for a flattened array, so I instead picked more relevant options 
> to test across. I also refactored the whole test so it becomes more readable. 
> The actual data tested on remains untouched.
> 
> The jtreg runner was also missing a couple of configurations, had a bad gtest 
> specifier, and had a flag misspelled, so I fixed all those as well.
> 
> Testing:
> - Tier 1
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Casper Norrbin has updated the pull request incrementally with one additional 
commit since the last revision:

  removed unneeded modules

-------------

Changes:
  - all: https://git.openjdk.org/valhalla/pull/2383/files
  - new: https://git.openjdk.org/valhalla/pull/2383/files/8a49f75c..e144da38

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2383&range=01
 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2383&range=00-01

  Stats: 12 lines in 1 file changed: 0 ins; 12 del; 0 mod
  Patch: https://git.openjdk.org/valhalla/pull/2383.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2383/head:pull/2383

PR: https://git.openjdk.org/valhalla/pull/2383

Reply via email to