On Mon, 4 May 2026 15:37:54 GMT, Paul Hübner <[email protected]> wrote:
>> Casper Norrbin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed unneeded modules
>
> test/hotspot/gtest/oops/test_objArrayOop.cpp line 99:
>
>> 97:
>> 98: for (const FlatArraySizeCase c : flatCases) {
>> 99: if (c.objal == (int)ObjectAlignmentInBytes) {
>
> Is there a reason you skip coops/COH here but not for the ref array?
coops/COH does not affect the flattened array size calculation so I did not
feel it was needed to restrict the check here.
> test/hotspot/jtreg/gtest/ObjArrayTests.java line 33:
>
>> 31: * @summary Run object array size tests with compressed oops
>> 32: * @library /test/lib
>> 33: * @modules java.base/jdk.internal.misc
>
> I don't think these `@modules` are required, other `GTestWrapper` tests don't
> use them.
Thanks for spotting that, I removed all the `@modules` from all the cases.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2383#discussion_r3186987356
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2383#discussion_r3186982607
