On Wed, 6 May 2026 03:30:38 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - review: add explaining comment to new test
>> - fix build error in new test on Windows
>
> test/hotspot/jtreg/serviceability/jvmti/valhalla/SampledObjectAllocValue/libSampledObjectAllocValue.cpp
> line 67:
>
>> 65: void JNICALL
>> 66: VMInit(jvmtiEnv* jvmti, JNIEnv* jni, jthread thread) {
>> 67: if (events_counter != 0) {
>
> You can check this in `Java_SampledObjectAllocValue_enableEvents`
> and get rid of VMInit.
Good suggestion, thanks. Fixed now.
> test/hotspot/jtreg/serviceability/jvmti/valhalla/VMObjectAllocValue/libVMObjectAllocValueTest.cpp
> line 49:
>
>> 47: }
>> 48:
>> 49: char *signature = nullptr;
>
> Not critical, but needed to deallocate signature.
Thanks. Fixed now.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2386#discussion_r3192954112
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2386#discussion_r3192962814
