On Wed, 6 May 2026 03:47:01 GMT, Leonid Mesnik <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - review: add explaining comment to new test
>> - fix build error in new test on Windows
>
> test/hotspot/jtreg/serviceability/jvmti/valhalla/VMObjectAllocValue/libVMObjectAllocValueTest.cpp
> line 60:
>
>> 58: if (object != nullptr) {
>> 59: fatal(jni, "Failed: object parameter for value object alloc is
>> expected to be nullptr");
>> 60: }
>
> Also check make sense to check size, at least for non-zero.
Thanks, added check for size.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2386#discussion_r3193002551