On Wed, 6 May 2026 04:56:14 GMT, Serguei Spitsyn <[email protected]> wrote:

>> This PR implements two JVMTI enhancements: 
>> [8382702](https://bugs.openjdk.org/browse/JDK-8382702) and 
>> [8381063](https://bugs.openjdk.org/browse/JDK-8381063)
>> 
>> The update includes the following changes:
>>  - add spec clarifications for `VMObjectAlloc` and `SampledObjectAlloc` 
>> related to value object allocations
>>  - pass `nullptr` for `jobject` parameter of `VMObjectAlloc` and 
>> `SampledObjectAlloc` event callbacks
>>  - add test coverage with value object allocations for both event callbacks
>> 
>> Testing:
>>  - Test locally with newly added tests
>>  - Run mach5 tiers 1-6
>>  
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Serguei Spitsyn has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   review: minor test tweaks: more checks, remove unneded code, add a comment 
> with assumption

src/hotspot/share/prims/jvmti.xml line 13991:

> 13989:       Virtual machines which are incapable of bytecode instrumentation
> 13990:       for some or all of their methods can send this event.
> 13991:       When preview features are enabled and an allocated object has no 
> identity, the

Suggestion:

      When preview features are enabled and an allocated object has no identity,

src/hotspot/share/prims/jvmti.xml line 14086:

> 14084:       <functionlink id="GetStackTrace"></functionlink>, a user can 
> track which objects were allocated from which
> 14085:       stack trace, and which are still live during the execution of 
> the program.
> 14086:       When preview features are enabled and an allocated object has no 
> identity, the

Suggestion:

      When preview features are enabled and an allocated object has no identity,

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2386#discussion_r3193460649
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2386#discussion_r3193462521

Reply via email to