On Wed, 6 May 2026 08:52:31 GMT, Tobias Hartmann <[email protected]> wrote:
>> To re-enable the autobox cache, this patch reverts (parts of) >> [JDK-8369921](https://bugs.openjdk.org/browse/JDK-8369921), >> [JDK-8378476](https://bugs.openjdk.org/browse/JDK-8378476), deopt parts of >> [JDK-8378531](https://bugs.openjdk.org/browse/JDK-8378531) and >> [JDK-8379148](https://bugs.openjdk.org/browse/JDK-8379148). >> >> I had to modify the `newCacheArray` methods to return a non-flattened array >> to avoid buffering. >> >> I wasn't sure about the comments above the `valueOf` methods: >> https://github.com/openjdk/valhalla/commit/b3ccb6abfdb6e2bff59a7d79bf01b669ac319257#diff-6136f7a80110ec00bf9a0b7da9943eb2fc33025ab400bc1f70153c1b2ac36993R146 >> >> Should they be reverted too? For now, I left them as is. >> >> Thanks, >> Tobias >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Tobias Hartmann has updated the pull request incrementally with one > additional commit since the last revision: > > Update src/hotspot/share/opto/type.cpp src/hotspot/share/opto/type.cpp line 330: > 328: guarantee(require_constant || > oop_constant->should_be_constant(), "con_type must get computed"); > 329: con_type = TypeOopPtr::make_from_constant(oop_constant, > require_constant); > 330: if (is_autobox_cache) { Suggestion: if (Compile::current()->eliminate_boxing() && is_autobox_cache) { ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2390#discussion_r3194133352
