On Thu, 7 May 2026 00:22:24 GMT, Ioi Lam <[email protected]> wrote: >> src/java.base/share/classes/java/lang/Character.java line 9442: >> >>> 9440: >>> 9441: // Load and use the archived cache if it exists >>> 9442: if (!PreviewFeatures.isEnabled()) { >> >> I don't think there is anything preventing us from using the CDS archive. >> We're currently archiving the `cache` even when running with >> `--enable-preview`, just not loading it. > > I think it's not necessary. I have a patch that removes this check around the > CDS code. I ran all the CDS tests that have `--enable-preview` in them and > they all passed. I'll try to run more tests now. > > https://github.com/iklam/valhalla/commit/a91c40735d760be7d160f2d72e53f48fecb08b49
@iklam's patch seems to work but I want to point out that `ArchivedIntegerCacheTest.java` needs to be updated: `@requires !java.enablePreview` should be removed. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2390#discussion_r3203278264
