On Thu, 7 May 2026 17:02:08 GMT, Matias Saavedra Silva <[email protected]> wrote:
>> I think it's not necessary. I have a patch that removes this check around >> the CDS code. I ran all the CDS tests that have `--enable-preview` in them >> and they all passed. I'll try to run more tests now. >> >> https://github.com/iklam/valhalla/commit/a91c40735d760be7d160f2d72e53f48fecb08b49 > > @iklam's patch seems to work but I want to point out that > `ArchivedIntegerCacheTest.java` needs to be updated: > `@requires !java.enablePreview` should be removed. Thanks! I applied Ioi's fix and updated `ArchivedIntegerCacheTest.java`. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2390#discussion_r3233493202
