On Wed, 6 May 2026 08:55:58 GMT, Tobias Hartmann <[email protected]> wrote:

>> To re-enable the autobox cache, this patch reverts (parts of) 
>> [JDK-8369921](https://bugs.openjdk.org/browse/JDK-8369921), 
>> [JDK-8378476](https://bugs.openjdk.org/browse/JDK-8378476), deopt parts of 
>> [JDK-8378531](https://bugs.openjdk.org/browse/JDK-8378531) and 
>> [JDK-8379148](https://bugs.openjdk.org/browse/JDK-8379148).
>> 
>> I had to modify the `newCacheArray` methods to return a non-flattened array 
>> to avoid buffering.
>> 
>> I wasn't sure about the comments above the `valueOf` methods:
>> https://github.com/openjdk/valhalla/commit/b3ccb6abfdb6e2bff59a7d79bf01b669ac319257#diff-6136f7a80110ec00bf9a0b7da9943eb2fc33025ab400bc1f70153c1b2ac36993R146
>> 
>> Should they be reverted too? For now, I left them as is.
>> 
>> Thanks,
>> Tobias
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Tobias Hartmann has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Update src/hotspot/share/opto/type.cpp

Thanks for the reviews! I've been working on 
https://git.openjdk.org/valhalla/pull/2406 which was blocking this PR and will 
get to this next week.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2390#issuecomment-4407053391

Reply via email to