On Fri, 8 May 2026 13:50:37 GMT, Coleen Phillimore <[email protected]> wrote:

>> Add a bunch of stubs and parameter changes to get non-Oracle platforms to 
>> compile.  Tested with cross compilation in mach5.  Also enabled GHA for 
>> these platforms.  Tested tier1 with Oracle platforms.
>> 
>> Porters please let me know if this runs hello world, then the rest is up to 
>> you.
>> Thank you!
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Coleen Phillimore has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Some code review fixes

src/hotspot/share/cds/filemap.cpp line 96:

> 94: #ifdef _LP64
> 95: inline void CDSMustMatchFlags::do_print(outputStream* st, uint v) {
> 96:   st->print("%u", v);

Doesn't %u print the same thing as %zu if I pass a uint to 
do_print(outputStream* st, uintx v)?  I think you can actually delete this 
function.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2396#discussion_r3211103517

Reply via email to