On Fri, 8 May 2026 20:18:20 GMT, Dean Long <[email protected]> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Some code review fixes
>
> src/hotspot/share/cds/filemap.cpp line 96:
> 
>> 94: #ifdef _LP64
>> 95: inline void CDSMustMatchFlags::do_print(outputStream* st, uint v) {
>> 96:   st->print("%u", v);
> 
> Doesn't %u print the same thing as %zu if I pass a uint to 
> do_print(outputStream* st, uintx v)?  I think you can actually delete this 
> function.

removing it makes linux-aarch64 very unhappy.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2396#discussion_r3211184967

Reply via email to