On Thu, 14 May 2026 13:03:52 GMT, Frederic Parain <[email protected]> wrote:
> Here's a patch adding argument validation to the factories for the special > arrays. > It also aligns the semantic of these factories with other ways to create > arrays with respect to the initialization state of the element type. > Some compiler tests needed adjustments because of the new code shape of the > factories. > > Thank you. > > --------- > - [X] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/hotspot/share/prims/jvm.cpp line 585: > 583: > 584: assert(klass->is_objArray_klass(), "Expects an object array"); > 585: Commenting on this one because I've been tweaking this function: I don't think this removal makes the code easier to read. The other sections below have blank lines to aid readability. test/hotspot/jtreg/runtime/valhalla/inlinetypes/TestArrayFactories.java line 305: > 303: } > 304: } > 305: } GitHub complains about lacking newline. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2435#discussion_r3242058362 PR Review Comment: https://git.openjdk.org/valhalla/pull/2435#discussion_r3242063634
