On Fri, 15 May 2026 14:10:56 GMT, Frederic Parain <[email protected]> wrote:

>> Here's a patch adding argument validation to the factories for the special 
>> arrays.
>> It also aligns the semantic of these factories with other ways to create 
>> arrays with respect to the initialization state of the element type.
>> Some compiler tests needed adjustments because of the new code shape of the 
>> factories.
>> 
>> Thank you.
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Frederic Parain has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Remove duplicated IR verification rules

src/java.base/share/classes/jdk/internal/value/ValueClass.java line 155:

> 153:                                              int length) {
> 154:       validateArrayArguments(componentType, length);
> 155:       return newReferenceArray0(componentType, length);

Indentation

src/java.base/share/classes/jdk/internal/value/ValueClass.java line 165:

> 163:      */
> 164:     @ForceInline
> 165:     public static  boolean isFlatArray(Object[] array) {

Suggestion:

    public static boolean isFlatArray(Object[] array) {

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2435#discussion_r3249026783
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2435#discussion_r3249027612

Reply via email to