On Mon, 8 Jun 2026 15:19:15 GMT, Frederic Parain <[email protected]> wrote:
>> Here's a patch adding argument validation to the factories for the special >> arrays. >> It also aligns the semantic of these factories with other ways to create >> arrays with respect to the initialization state of the element type. >> Some compiler tests needed adjustments because of the new code shape of the >> factories. >> >> Thank you. >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Frederic Parain has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 16 commits: > > - Merge remote-tracking branch 'upstream/lworld' into fact_valid > - Exclude main method from C1 compilation > - Make native factory methods private > - Merge remote-tracking branch 'upstream/lworld' into fact_valid > - Fixes in handling of non-flat arrays > - Temporarely disable test > - Remove duplicated IR verification rules > - Fix IR verification rules > - Fix ndentation > - Restore blank lines > - ... and 6 more: > https://git.openjdk.org/valhalla/compare/246ffbf1...4aece1f3 src/hotspot/share/opto/parse2.cpp line 108: > 106: const TypeInt* sizetype = ary_type->size(); > 107: Node* ref_adr = array_element_address(not_flat_ary, array_index, > bt, sizetype, control()); > 108: assert(ref_adr != top(), "top should go hand-in-hand with > stopped"); Nit: there is `bool Node::is_top() const` ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2435#discussion_r3374390846
