On Fri, 22 May 2026 21:44:53 GMT, Dan Heidinga <[email protected]> wrote:
>> Casper Norrbin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Validate archived inline field dependencies without LoadableDescriptors
>
> src/hotspot/share/classfile/systemDictionary.cpp line 1214:
>
>> 1212: }
>> 1213: } else {
>> 1214: // Pending exceptions are cleared so we can fail silently.
>
> Do we need this branch to attempt to preload? As long as we have the classes
> for the flattened fields, we should be OK. I would expect the other classes
> to be optional at this point
This branch handles the speculative preloading from the `LoadableDescriptors`
attribute for non-flat nullable fields, so it is not part of the required
flat/null-restricted validation. I kept it to preserve the existing behavior
where `LoadableDescriptors` can opportunistically load field classes. These
loads are optional, failures are ignored and should not cause the shared
loading to fail.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2409#discussion_r3298070755
