On Mon, 25 May 2026 14:05:40 GMT, Dan Heidinga <[email protected]> wrote:
>> This branch handles the speculative preloading from the >> `LoadableDescriptors` attribute for non-flat nullable fields, so it is not >> part of the required flat/null-restricted validation. I kept it to preserve >> the existing behavior where `LoadableDescriptors` can opportunistically load >> field classes. These loads are optional, failures are ignored and should not >> cause the shared loading to fail. > > I'm fine with leaving this for now but we should think further about this > after the merge to mainline. With CDS, these field classes for non-flat > fields will be loaded during `ik->link_class()` so this may be additional > complexity we can simplify The comments needs to be clarified. It says "we can fail silently", but we just ignore any failures and keep on executing. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2409#discussion_r3364687116
