On Wed, 17 Jun 2026 13:18:04 GMT, Chen Liang <[email protected]> wrote:
>> Can I please get a review of this change which specifies that the >> `IdentityException` throws a `NullPointerException` if the `Class` passed to >> its constructor is null? >> >> This change is being proposed as part of the JEP-401 standard library >> changes that are currently under review at >> https://github.com/openjdk/jdk/pull/31123. >> >> A new jtreg test has been introduced to verify the basic semantics of this >> exception class. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > test/jdk/java/lang/IdentityExceptionBasicTest.java line 1: > >> 1: /* > > I thought the jtreg directive block is supposed to appear before imports > instead of after. Is there a convention on this? Hello Chen, there are several tests in the JDK which place the test definition right above the test class declaration. There are many other tests too which place this before the imports. To me, keeping it closer to the test class makes it easier to spot the test details. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2562#discussion_r3428467215
