On Wed, 17 Jun 2026 08:26:54 GMT, Jaikiran Pai <[email protected]> wrote:

> Can I please get a review of this change which specifies that the 
> `IdentityException` throws a `NullPointerException` if the `Class` passed to 
> its constructor is null?
> 
> This change is being proposed as part of the JEP-401 standard library changes 
> that are currently under review at https://github.com/openjdk/jdk/pull/31123.
> 
> A new jtreg test has been introduced to verify the basic semantics of this 
> exception class.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

> Hello Joe @jddarcy, in context of the discussion about the constructors in 
> this exception class [openjdk/jdk#31123 
> (comment)](https://github.com/openjdk/jdk/pull/31123#discussion_r3416119896), 
> I can also remove the unused constructors in this PR, if you and others 
> suggest so.

On second thoughts, when working on something else in this area, I realized 
that there are places in the native (VM) code which can throw the 
`IdentityException` and I haven't verified that the constructors that I was 
considering to remove aren't being called from that layer. So I won't do 
anything related to constructor removals in this PR and will reconsider it at a 
later date after.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2562#issuecomment-4730731955

Reply via email to