> On Wednesday 22 August 2007, Rick Widmer wrote: >> http://vpopmail.sf.net/ >> >> 5.4.20 - released 21-Aug-07 > > Feels odd to ask this, but in the UPGRADE document, it lists the > "pw_domain" > columns as requiring updates, but my databases have just "domain" in them > except for the vpopmail table. > > I've upgraded them manually, but should I be re-naming the columns > manually? > I'd prefer not to take the plunge and ask instead. :) > > Moving from 5.4.17. > Looks like there was a bit of a disconnect early in the coding process (well before I ever heard of vpopmail, which was in the 5.3.x era), and only the vpopmail table has a 'pw_domain' column (to match the rest of the password structure naming, I assume). All of the other tables have a 'domain' column, instead. So I made an error when I wrote the fix and updated the UPGRADE document for 5.4.18 (I think it was that), and incorrectly labelled the column name for vpopmail 'domain' instead of 'pw_domain'.
Thus, the relevant section of UPGRADE should really be: ALTER TABLE `dir_control` CHANGE `domain` `domain` CHAR(96) NOT NULL; ALTER TABLE `ip_alias_map` CHANGE domain domain CHAR(96) NOT NULL; ALTER TABLE `lastauth` CHANGE domain domain CHAR(96) NOT NULL; ALTER TABLE `valias` CHANGE domain domain CHAR(96) NOT NULL; ALTER TABLE `vlog` CHANGE domain domain CHAR(96) NOT NULL; ALTER TABLE `vpopmail` CHANGE pw_domain pw_domain CHAR(96) NOT NULL; ALTER TABLE `limits` CHANGE domain domain CHAR(96) NOT NULL, ADD `disable_spamassassin` TINYINT(1) DEFAULT '0' NOT NULL AFTER `disable_smtp`, ADD `delete_spam` TINYINT(1) DEFAULT '0' NOT NULL AFTER `disable_spamassassin`; Note that this is mostly what it said before, with the vpopmail table line changed to pw_domain instead of domain. Sorry I didn't catch this before it was released... Ideally I would think that the column names should be consistent across the tables, but that would cause mandatory breakage, and probably should be held back for a more major release (redo 5.5 or go to 5.6?). At least people will have a greater expectation of needing to read the docs carefully on somethign bigger than a point upgrade :) Josh Joshua Megerman SJGames MIB #5273 - OGRE AI Testing Division You can't win; You can't break even; You can't even quit the game. - Layman's translation of the Laws of Thermodynamics [EMAIL PROTECTED]