-1
Sorry to a stick in the mud, guys, since I'd certainly like to see 2.3 released
soon, but I encountered a few issues that I think should be fixed before
cutting the release.
I installed the release candidate using a fresh database, testing against a
vCenter provisioning engine and Shibboleth authentication. I was using a 64-bit
Windows 7 image.
The first issue I encountered was that each time the management node calls
'get_file_contents', the contents of the target file are printed to the log.
This is generally not an issue, but when a slice of the registry is retrieved,
that amounted to ~30,000 lines in my logfile. And that happens each time an
image is reloaded. (Somehow I hadn't noticed this with the code from about two
weeks ago). I can certainly see the usefulness of this during development, but
I don't like the fact that this is the default behavior for a release. For now,
I would suggest modifying line 1789 of OS.pm:
- my ($exit_status, $output) = $self->execute($command);
+ my ($exit_status, $output) = $self->execute($command, 0); # do not print
the cmd output to the log
Later, it could be nice to make this somewhat more configurable.
Second, if the system is using Shibboleth it is not possible to handle users
who have not previously logged in (i.e. adding someone to a group). There are
two bugs preventing this from working properly. First, if someone enables
ALLOWADDSHIBUSERS in conf.php but doesn't define a value in $addUserFuncArgs (I
would anticipate this to be what most people using Shib would do, since there
is no documentation about what that array is for), the initGlobals() function
does not properly populate the addUserFuncArgs array. This can be fixed by
adding $addUserFuncArgs to the list of 'global' values on line 68 in utils.php
-- the current code is just modifying a local value, not the global one:
- global $affilValFunc, $addUserFunc, $updateUserFunc;
+ global $affilValFunc, $addUserFunc, $updateUserFunc, $addUserFuncArgs;
Once that change is made, though, there is also a SQL query expecting a
'validated' field in the users table. This field, however, does not exist. It
is in neither update-vcl.sql nor in vcl.sql:
vcl.sql, line 1079:
+ `validated` tinyint(1) unsigned NOT NULL default '1',
and update-vcl.sql, lines 827-
+ -- --------------------------------------------------------
+
+ --
+ -- Table structure for table `user`
+ --
+
+ CALL AddColumnIfNotExists('user', 'validated', "tinyint(1) unsigned NOT NULL
default '1'");
+
Once these two changes are made, however, I am able to add shib users exactly
as the documentation suggests.
Otherwise, everything else looks good.
Aaron
--
Aaron Coburn
Systems Administrator and Programmer
Academic Technology Services, Amherst College
acob...@amherst.edu<mailto:acob...@amherst.edu>
On May 30, 2012, at 2:58 PM, Josh Thompson wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Kevan,
Correct - VCL is all in scripted languages; so, there are no binary releases.
I've avoided maintaining dojo in subversion both to keep the repo a little
cleaner and to avoid the problem of ending up with an old copy in there that
never gets updated.
I'll start a separate thread to discuss if others would like dojo in the repo.
Josh
On Wednesday, May 30, 2012 10:57:41 AM Kevan Miller wrote:
Here's my +1
Source, LICENSE/NOTICE, RAT, signature/checksum -- all look good to me.
Seem to recall a discussion on this before, but just to be sure. Apache
releases source code. PMC's vote on source releases. Many ASF projects also
have binary distributions (which a PMC also evaluates and uses in
evaluating the correctness of the release). The binaries are also
convenient for many users. So, you end up with source and binary
distributions of a project.
There is no VCL binary/compilation (that I know of). So, the VCL release is
a *source* release. One thing to note is that we don't maintain dojo in svn
(we could do so).
--kevan
On May 29, 2012, at 4:36 PM, Josh Thompson wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
We've finally reached a point where we do not seem to be finding any more
bugs.
I created a release artifact based off of trunk. I copied trunk to a tag
under the tags area of the repo that is named release-2.3-RC1:
http://svn.apache.org/repos/asf/incubator/vcl/tags/release-2.3-RC1/
The artifact is an export from that tag with the addition of Dojo Toolkit
version 1.6.1 with a custom VCL profile bundled in the web code. The
artifact, MD5 and SHA1 sums, and my GPG signature of it are available from
my space on people.a.o:
http://people.apache.org/~jfthomps/apache-VCL-2.3-RC1-incubating/
The list of resolved JIRA issues associated with this release can be found
under Change Log on the VCL 2.3 release page:
https://cwiki.apache.org/VCL/vcl-23.html#VCL2.3-ChangeLog
Installation instructions are on the Confluence site and in the
INSTALLATION file included in the artifact.
I was able to successfully do a test install, including image deploying
and
capture.
The directory created by extracting the RC1 artifact is
"apache-VCL-2.3-RC1-incubating" (after extracting, you may want to rename
it to "apache-VCL-2.3-incubating" so you can copy and paste all of the
commands in the installation guide). Licensing information about perl
and its required modules, php and its required modules, and mysql are
stated as "system requirements" according to the information under
"System Requirements" on http://www.apache.org/legal/3party.html.
Please vote by the end of the day on Friday, June 1st to publish this
release (this allows for 3 business days to vote). Please note that
anyone in the VCL community is allowed to vote.
[ ] +1 yes, release VCL 2.3
[ ] 0 dunno
[ ] -1 no, don't release VCL 2.3 (provide reasons if this is your vote)
Josh
- --
- -------------------------------
Josh Thompson
VCL Developer
North Carolina State University
my GPG/PGP key can be found at pgp.mit.edu<http://pgp.mit.edu>
All electronic mail messages in connection with State business which
are sent to or received by this account are subject to the NC Public
Records Law and may be disclosed to third parties.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
iEYEARECAAYFAk/FMzYACgkQV/LQcNdtPQNOIwCfVwta+LYh0W+7tj9B39j5Owb0
LPsAn29HkFQmU3lV2U54VrGsx2C4hZrg
=8DZ2
-----END PGP SIGNATURE-----
- --
- -------------------------------
Josh Thompson
VCL Developer
North Carolina State University
my GPG/PGP key can be found at pgp.mit.edu<http://pgp.mit.edu>
All electronic mail messages in connection with State business which
are sent to or received by this account are subject to the NC Public
Records Law and may be disclosed to third parties.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
iEYEARECAAYFAk/GbdoACgkQV/LQcNdtPQNtiQCfUi3/ZctI9H2i5Q+8jAgJtHAI
scQAn3NPQN9tdAzB1T4gXTaxzx3FJTKo
=lEHU
-----END PGP SIGNATURE-----
