----- Original Message ----- > From: "Michal Skrivanek" <[email protected]> > To: "Dan Kenigsberg" <[email protected]>, "Itamar Heim" <[email protected]>, > [email protected] > Cc: [email protected] > Sent: Thursday, August 22, 2013 9:53:50 AM > Subject: Re: [vdsm] suggesting new Vdsm maintaniner(s) > > > On Aug 8, 2013, at 11:00 , Dan Kenigsberg <[email protected]> wrote: > > > On Thu, Aug 01, 2013 at 04:55:07PM +0300, Dan Kenigsberg wrote: > >> Nominating Toni Puimedon and/or Mark Wu as maintainers > >> ====================================================== > >> > >> During their recent year-or-two of participation in Vdsm development, > >> both Toni and Mark has demonstrated a genuine care for the health and > >> evolution of the the project. > >> > >> They both carry this hard-to-quantify quality of serious-mindedness when > >> reviewing patches. > >> > >> Toni's 73 committed patches touch everything that is related to network > >> configuration and reporting > >> > >> 27 vdsm/configNetwork.py > >> 11 lib/vdsm/netinfo.py > >> 8 vdsm/API.py > >> 8 tests/configNetworkTests.py > >> 7 vdsm/netinfo.py > >> 7 vdsm/netconf/ifcfg.py > >> 5 vdsm/libvirtvm.py > >> 4 vdsm/netmodels.py > >> > >> ... similar to Mark's 80: > >> > >> 16 vdsm/configNetwork.py > >> 12 vdsm/netconf/ifcfg.py > >> 12 vdsm/libvirtvm.py > >> 7 vdsm/clientIF.py > >> 6 lib/vdsm/netinfo.py > >> 5 vdsm/caps.py > >> 5 vdsm/API.py > >> 4 vdsm/vm.py > >> 4 vdsm/netmodels.py > >> 4 vdsm/Makefile.am > >> > >> I suggest that both of them obtain +2/-2 rights, in the understanding > >> that they are to be used on net-related parts of the code. This is > >> particularly important given my nearing, relatively long, vacation. > >> > >> What do you say? > > > > We've got no objectation, but neither an overwhelming support. Maybe > > it's due to the summer season. > > Likely. My late loud +1 > > > > To me, it is important to tell whether Toni/Mark only reviewed a patch > > (+1) or are completely standing behind it, and going to fix bugs in it > > if the author is run over by a bus (God forbid). > > > > Itamar and other board members: if there is no objection within, say, > > one week, would you grant the duo +2 rights? > > Sounds like the time is now…
Agreed, delaying it just overloads Federico during the recent period. With adding new maintainers I hope we'll have more attendance in vdsm calls and contributes will receive faster response and help Thanks, Yaniv Bronhaim. > > > > Dan. > > _______________________________________________ > > vdsm-devel mailing list > > [email protected] > > https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel > > _______________________________________________ > vdsm-devel mailing list > [email protected] > https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel > _______________________________________________ vdsm-devel mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-devel
