Lei Li has posted comments on this change. Change subject: Add passwd command to vdsm-tool ......................................................................
Patch Set 2: (2 inline comments) .................................................... File vdsm-tool/passwd.py Line 36: if os.path.exists(PASSWORD_FILE): This passwd file is installed at the step vdsm installed, which means it would be there when this command be called from vdsm-tool, so I didn't consider the situation it doesn't exist... But your suggestion sound good, ok, I will modify it later. Line 38: sys.stdin = open(PASSWORD_FILE, 'r') Sorry, I don't understand your point. Do you mean sys.stdin is not good here? Can you let me know why? -- To view, visit http://gerrit.ovirt.org/4528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b5aee4c2f11a7680c675c171ff35a463a70402 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Lei Li <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Wenyi Gao <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
