Lei Li has posted comments on this change.

Change subject: Add passwd command to vdsm-tool
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm.spec.in
Line 364
Hi Adam,

You are right. So the point is whether the vdsm-tool command should be called 
here.

If yes, will add line like "%{_bindir/vdsm-tool update-saslpasswd2}", but the 
question is does it make sense to call an vdsm-tool command here?  Then what's 
the meaning of moving these code into vdsm-tool module?

If no, have to set the password by run the vdsm-tool command manually, of 
course the previous package installation process would be changed.

Dan, Federico, Ryan, any ideas?

--
To view, visit http://gerrit.ovirt.org/4528
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76b5aee4c2f11a7680c675c171ff35a463a70402
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Lei Li <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to