Lei Li has posted comments on this change. Change subject: Move and encapsulate preun section into vdsm-tool ......................................................................
Patch Set 1: (3 inline comments) .................................................... File vdsm.spec.in Line 372: %preun Yes, you are right. After the discussion on vdsm-devel mailing list, will call vdsm-tool command here. .................................................... File vdsm/vdsm-unregister.in Line 1: !/bin/bash Sorry for my negligence... Just tested on fedora, I will test it on el6 too. Line 23: /usr/sbin/saslpasswd2 -p -a libvirt -d vdsm@rhevh Good idea, I will add it in a separate patch after passwd module accepted. -- To view, visit http://gerrit.ovirt.org/4526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7b5dc969dfb51e6880b9bb209a363609f5e123 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <li...@linux.vnet.ibm.com> Gerrit-Reviewer: Adam Litke <a...@us.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Lei Li <li...@linux.vnet.ibm.com> Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
